Update compare.py._parse_input_rdms #453
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure nan positions in each input RDM match.
|
Good catch @JonathanShor ! I'd like us to have a unit test to make sure this won't be re-introduced in the future. If you have a chance to add this, great, otherwise I'll aim to add one later this week. PS please ignore the style and typing checks, these are not working rn. |
|
Sure, I could add something like my example in #452. Are there docs on how your testing is setup? Or point me to an example test and a location I can add the new one, that would be great. |
Identify positions in any component RDM that are NaN, and propagates them across. Only raises an error if rdm1 and rdm2 disagree on NaN placement after internal propagation. Renamed nan_idx to nan_mask since the True values are not for the NaNs.
|
Corrected for the case that rdm1 and rdm2 have different n_rdm. Had NaNs propagate across RDMs within rdm1 or rdm2, and it only raises an error if the positions disagree after this propagation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure nan positions in each input RDM match.
Addresses #452