Skip to content

Update compare.py._parse_input_rdms #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update compare.py._parse_input_rdms #453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3849bf5
Update compare.py._parse_input_rdms
JonathanShor Jul 31, 2025
98d6800
Handle rdm1 and rdm2 having different n_rdm
JonathanShor Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/rsatoolbox/rdm/compare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,12 +671,14 @@ def _parse_input_rdms(rdm1, rdm2):
vector2 = rdm2
if not vector1.shape[1] == vector2.shape[1]:
raise ValueError('rdm1 and rdm2 must be RDMs of equal shape')
nan_idx = ~np.isnan(vector1)
vector1_no_nan = vector1[nan_idx].reshape(vector1.shape[0], -1)
vector2_no_nan = vector2[~np.isnan(vector2)].reshape(vector2.shape[0], -1)
if not vector1_no_nan.shape[1] == vector2_no_nan.shape[1]:
# A NaN in any RDM means that position must be excluded from all
nan_mask = ~np.isnan(vector1).any(axis=0)
if not np.all(nan_mask == ~np.isnan(vector2).any(axis=0)):
# Only raise error when rdm1 and rdm2 conflict
raise ValueError('rdm1 and rdm2 have different nan positions')
return vector1_no_nan, vector2_no_nan, nan_idx[0]
vector1_no_nan = vector1[:,nan_mask].reshape(vector1.shape[0], -1)
vector2_no_nan = vector2[:,nan_mask].reshape(vector2.shape[0], -1)
return vector1_no_nan, vector2_no_nan, nan_mask


def _sq_bures_metric_first_way(A, B):
Expand Down