Pegin it register btc tx negative height #2888
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
julianlen
force-pushed
the
pegin-it-registerBtcTx-negativeHeight
branch
2 times, most recently
from
de4c30f to
b699b73
Compare
julianlen
force-pushed
the
pegin-it-repeatedTx
branch
from
ea9584e to
171c569
Compare
julianlen
force-pushed
the
pegin-it-registerBtcTx-negativeHeight
branch
from
b699b73 to
171c569
Compare
julianlen
force-pushed
the
pegin-it-repeatedTx
branch
from
171c569 to
3d5d7e9
Compare
julianlen
force-pushed
the
pegin-it-registerBtcTx-negativeHeight
branch
3 times, most recently
from
fac66b3 to
25c1834
Compare
julianlen
force-pushed
the
pegin-it-repeatedTx
branch
from
e4f10cd to
68a0f15
Compare
julianlen
force-pushed
the
pegin-it-registerBtcTx-negativeHeight
branch
3 times, most recently
from
a4aee36 to
be35cf6
Compare
julianlen
force-pushed
the
pegin-it-registerBtcTx-negativeHeight
branch
from
be35cf6 to
bc71e17
Compare
jeremy-then
reviewed
Dec 19, 2024
| List<UTXO> expectedFederationUTXOs = federationSupport.getActiveFederationBtcUTXOs(); | ||
|
|
||
| // Act | ||
| bridgeSupport.registerBtcTransaction(rskTx, bitcoinTransaction.bitcoinSerialize(), -1, pmtWithTransactions.bitcoinSerialize()); |
There was a problem hiding this comment.
Based on the logic internal logic, this should throw a new RegisterBtcTransactionException("Could not validate transaction").
There was a problem hiding this comment.
Interesting, this test should be failing then. Maybe we are missing something here?
There was a problem hiding this comment.
No exception is thrown because of negative height or repeated btc transactions. The exception is caught within the BridgeSupport::registerBtcTransaction method and it prints a log. I'll add this as a future issue to review.
apancorb
reviewed
Dec 19, 2024
Comment on lines
150
to
151
| @Test | ||
| void registerBtcTransaction_forALegacyBtcTransactionWithNegativeHeight_shouldNotPerformAnyChange() throws Exception { |
There was a problem hiding this comment.
Suggested change
| @Test | |
| void registerBtcTransaction_forALegacyBtcTransactionWithNegativeHeight_shouldNotPerformAnyChange() throws Exception { | |
| @Test | |
| void registerBtcTransaction_whenLegacyBtcTransactionWithNegativeHeight_shouldNotPerformAnyChange() throws Exception { |
| List<UTXO> expectedFederationUTXOs = federationSupport.getActiveFederationBtcUTXOs(); | ||
|
|
||
| // Act | ||
| bridgeSupport.registerBtcTransaction(rskTx, bitcoinTransaction.bitcoinSerialize(), -1, pmtWithTransactions.bitcoinSerialize()); |
There was a problem hiding this comment.
Interesting, this test should be failing then. Maybe we are missing something here?
julia-zack
reviewed
Dec 19, 2024
rskj-core/src/test/java/co/rsk/peg/RegisterBtcTransactionIT.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Dec 19, 2024
| @@ -169,7 +188,8 @@ private BtcTransaction createPegInTransaction(Address federationAddress, Coin co | |||
| private void assertLogPegInBtc() { | |||
| Sha256Hash peginTransactionHash = bitcoinTransaction.getHash(); | |||
| List<DataWord> encodedTopics = getEncodedTopics(BridgeEvents.PEGIN_BTC.getEvent(), rskReceiver.toString(), peginTransactionHash.getBytes()); | |||
| byte[] encodedData = getEncodedData(BridgeEvents.PEGIN_BTC.getEvent(), minimumPeginValue.getValue(), 0); | |||
| int protocolVersion = 0; | |||
julia-zack
approved these changes
Dec 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.