Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pegin it register btc tx negative height #2888

Open
wants to merge 6 commits into
base: pegin-it-repeatedTx
Choose a base branch
from
+25 −5
Open

Pegin it register btc tx negative height #2888

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bc71e17
feat: added a test to check a tx with negative block height is invalid
julianlen Dec 13, 2024
f8b37f5
fix: improved title for the test
julianlen Dec 19, 2024
a80be0c
fix: federationBtcUTXOs are passed as reference, now it makes a copy
julianlen Dec 19, 2024
97d1f9b
fix: changed to List.of instead of Collections.singletonList
julianlen Dec 19, 2024
28ccc6c
fix: extra space
julianlen Dec 19, 2024
ea055ed
fix: no magic numbers, extracted them as variables
julianlen Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions rskj-core/src/test/java/co/rsk/peg/RegisterBtcTransactionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ void registerBtcTransaction_forALegacyBtcTransaction_shouldRegisterTheNewUtxoAnd

int outputIndex = 0;
TransactionOutput output = bitcoinTransaction.getOutput(outputIndex);
List<UTXO> expectedFederationUtxos = Collections.singletonList(utxoOf(bitcoinTransaction, output));
List<UTXO> expectedFederationUtxos = List.of(utxoOf(bitcoinTransaction, output));
assertEquals(expectedFederationUtxos, federationSupport.getActiveFederationBtcUTXOs());

co.rsk.core.Coin expectedReceiverBalance = co.rsk.core.Coin.fromBitcoin(output.getValue());
Expand All @@ -136,7 +136,7 @@ void registerBtcTransaction_forARepeatedLegacyBtcTransaction_shouldNotPerformAny
bridgeSupport.save();

co.rsk.core.Coin expectedReceiverBalance = repository.getBalance(rskReceiver);
List<UTXO> expectedFederationUTXOs = federationSupport.getActiveFederationBtcUTXOs();
List<UTXO> expectedFederationUTXOs = List.copyOf(federationSupport.getActiveFederationBtcUTXOs());

// Act
bridgeSupport.registerBtcTransaction(rskTx, bitcoinTransaction.bitcoinSerialize(), btcBlockWithPmtHeight, pmtWithTransactions.bitcoinSerialize());
Expand All @@ -147,6 +147,21 @@ void registerBtcTransaction_forARepeatedLegacyBtcTransaction_shouldNotPerformAny
assertEquals(expectedReceiverBalance, repository.getBalance(rskReceiver));
}

@Test
void registerBtcTransaction_whenLegacyBtcTransactionWithNegativeHeight_shouldNotPerformAnyChange() throws Exception {
// Arrange
co.rsk.core.Coin expectedReceiverBalance = repository.getBalance(rskReceiver);
List<UTXO> expectedFederationUTXOs = List.copyOf(federationSupport.getActiveFederationBtcUTXOs());

// Act
bridgeSupport.registerBtcTransaction(rskTx, bitcoinTransaction.bitcoinSerialize(), -1, pmtWithTransactions.bitcoinSerialize());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the logic internal logic, this should throw a new RegisterBtcTransactionException("Could not validate transaction").

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, this test should be failing then. Maybe we are missing something here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No exception is thrown because of negative height or repeated btc transactions. The exception is caught within the BridgeSupport::registerBtcTransaction method and it prints a log. I'll add this as a future issue to review.

julia-zack marked this conversation as resolved.
Show resolved Hide resolved
bridgeSupport.save();

// Assert
assertEquals(expectedFederationUTXOs, federationSupport.getActiveFederationBtcUTXOs());
assertEquals(expectedReceiverBalance, repository.getBalance(rskReceiver));
}

private static UTXO utxoOf(BtcTransaction bitcoinTransaction, TransactionOutput output) {
return new UTXO(
bitcoinTransaction.getHash(),
Expand Down
Loading