-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Databricks integration (#839) #841
Conversation
…mode of `purrr`, and improves some tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a request in to CloudOps to get access to Databricks so I can run the tests and such.
Co-authored-by: Julia Silge <[email protected]>
Co-authored-by: Julia Silge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for all this work @edgararuiz! 🙌
I was able to get access to Databricks and a Volume to test this myself, and all appears to be working well. I also added creds to CI so we can run the tests as part of the check-boards
job, which is working well.
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Details
board_databricks()
, with support forprefix
pin_list
,pin_exists
,pin_meta
,pin_store
,pin_versions
,pin_fetch
,pin_delete
,pin_version_delete
,board_deparse
andrequired_pkgs
test_api_basic()
,test_api_versioning()
,test_api_meta()
.Test Results
I am emulating how the other boards implement
required_pkgs
, but I still get Warnings. Not sure how to address, or if I should address it in this PR.(Fixes #839)