Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Databricks integration (#839) #841

Merged
merged 39 commits into from
Oct 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
5217fb6
Ports host and token functions
edgararuiz Sep 26, 2024
9ad829f
Starts board_databricks
edgararuiz Sep 26, 2024
9c3e7fe
Starts pin list
edgararuiz Sep 27, 2024
cfdac3e
Removes pipes
edgararuiz Sep 27, 2024
b93290c
Centralices content retreival adds pin_exists
edgararuiz Sep 27, 2024
991cccf
Starts pin_meta function
edgararuiz Sep 27, 2024
683b3bb
Simplifies arguments, renames token and host functions
edgararuiz Sep 27, 2024
1067d16
First pass at pin_store
edgararuiz Sep 27, 2024
3795be4
Fixex hashed subfolder
edgararuiz Sep 27, 2024
bca1c98
Adds pin_versions
edgararuiz Sep 27, 2024
ba0b5db
Improvements to cache path
edgararuiz Sep 28, 2024
6a8f9ec
Adds download file helper
edgararuiz Sep 28, 2024
333bb57
Adds download step to meta, fixes cache discovery
edgararuiz Sep 28, 2024
7288370
Adds pin_fetch
edgararuiz Sep 28, 2024
f0af322
Adds pin_delete, and all supporting functions
edgararuiz Sep 28, 2024
bf75613
Assignes proper file rights to local cache
edgararuiz Sep 29, 2024
c0a6d87
Passes all tests
edgararuiz Sep 29, 2024
697f84e
Adds board_deparse
edgararuiz Sep 29, 2024
555106c
Adds required_pkgs
edgararuiz Sep 29, 2024
19ea3b1
Starts testing
edgararuiz Sep 29, 2024
b491458
Avoids failing when checking contents of a folder, needed for prefix
edgararuiz Sep 29, 2024
5bee48c
Passes all tests
edgararuiz Sep 30, 2024
21cb48a
Fixes a pkg check finding
edgararuiz Sep 30, 2024
127ec9d
Starts documentation
edgararuiz Sep 30, 2024
be595f6
Completes documentation
edgararuiz Sep 30, 2024
6452b77
Adds NEWS item
edgararuiz Sep 30, 2024
c5bfbcc
Small fix to documentation, adds some instructions to tests
edgararuiz Sep 30, 2024
47de59a
Properly handles lack of host or token
edgararuiz Sep 30, 2024
bb0d8e2
Fixes pkg_down failure, address oldrel-4 issue by reverting to older …
edgararuiz Sep 30, 2024
9c8b88f
More consistent filename
juliasilge Oct 2, 2024
97c7de0
More consistent filename
juliasilge Oct 2, 2024
da9ef44
Edits to docs
juliasilge Oct 2, 2024
7517c81
Redocument
juliasilge Oct 2, 2024
de54a1f
Update R/board_databricks.R
edgararuiz Oct 2, 2024
f61d6b4
Update R/board_databricks.R
edgararuiz Oct 2, 2024
b77b67c
Removes reference to bucket, and re-documents
edgararuiz Oct 2, 2024
381b9d4
Little more doc refining
juliasilge Oct 2, 2024
4338be4
Try running tests in CI
juliasilge Oct 2, 2024
9b6af31
Update snapshot
juliasilge Oct 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/check-boards.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ jobs:
PINS_AWS_ACCESS_KEY: ${{ secrets.PINS_AWS_ACCESS_KEY}}
PINS_AWS_SECRET_ACCESS_KEY: ${{ secrets.PINS_AWS_SECRET_ACCESS_KEY}}
PINS_GCS_PASSWORD: ${{ secrets.PINS_GCS_PASSWORD }}
DATABRICKS_TOKEN: ${{ secrets.DATABRICKS_TOKEN }}
DATABRICKS_HOST: "https://rstudio-partner-posit-default.cloud.databricks.com"
PINS_DATABRICKS_FOLDER_URL: "/Volumes/workshops/models/vetiver"

# needed for legacy board tests
TEST_AWS_BUCKET: "pins-github-tests"
Expand Down
1 change: 1 addition & 0 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ Suggests:
gitcreds,
googleCloudStorageR,
googledrive,
httr2,
ids,
knitr,
Microsoft365R,
Expand Down
11 changes: 11 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ S3method(board_browse,pins_board_local)
S3method(board_deparse,pins_board)
S3method(board_deparse,pins_board_azure)
S3method(board_deparse,pins_board_connect)
S3method(board_deparse,pins_board_databricks)
S3method(board_deparse,pins_board_folder)
S3method(board_deparse,pins_board_gcs)
S3method(board_deparse,pins_board_kaggle_competition)
Expand Down Expand Up @@ -56,6 +57,7 @@ S3method(pin,data.frame)
S3method(pin,default)
S3method(pin_delete,pins_board_azure)
S3method(pin_delete,pins_board_connect)
S3method(pin_delete,pins_board_databricks)
S3method(pin_delete,pins_board_folder)
S3method(pin_delete,pins_board_gcs)
S3method(pin_delete,pins_board_gdrive)
Expand All @@ -66,6 +68,7 @@ S3method(pin_delete,pins_board_s3)
S3method(pin_delete,pins_board_url)
S3method(pin_exists,pins_board_azure)
S3method(pin_exists,pins_board_connect)
S3method(pin_exists,pins_board_databricks)
S3method(pin_exists,pins_board_folder)
S3method(pin_exists,pins_board_gcs)
S3method(pin_exists,pins_board_gdrive)
Expand All @@ -76,6 +79,7 @@ S3method(pin_exists,pins_board_s3)
S3method(pin_exists,pins_board_url)
S3method(pin_fetch,pins_board_azure)
S3method(pin_fetch,pins_board_connect)
S3method(pin_fetch,pins_board_databricks)
S3method(pin_fetch,pins_board_folder)
S3method(pin_fetch,pins_board_gcs)
S3method(pin_fetch,pins_board_gdrive)
Expand All @@ -86,6 +90,7 @@ S3method(pin_fetch,pins_board_s3)
S3method(pin_fetch,pins_board_url)
S3method(pin_list,pins_board_azure)
S3method(pin_list,pins_board_connect)
S3method(pin_list,pins_board_databricks)
S3method(pin_list,pins_board_folder)
S3method(pin_list,pins_board_gcs)
S3method(pin_list,pins_board_gdrive)
Expand All @@ -101,6 +106,7 @@ S3method(pin_load,package)
S3method(pin_load,table)
S3method(pin_meta,pins_board_azure)
S3method(pin_meta,pins_board_connect)
S3method(pin_meta,pins_board_databricks)
S3method(pin_meta,pins_board_folder)
S3method(pin_meta,pins_board_gcs)
S3method(pin_meta,pins_board_gdrive)
Expand All @@ -115,6 +121,7 @@ S3method(pin_search,pins_board_kaggle_competition)
S3method(pin_search,pins_board_kaggle_dataset)
S3method(pin_store,pins_board_azure)
S3method(pin_store,pins_board_connect)
S3method(pin_store,pins_board_databricks)
S3method(pin_store,pins_board_folder)
S3method(pin_store,pins_board_gcs)
S3method(pin_store,pins_board_gdrive)
Expand All @@ -126,6 +133,7 @@ S3method(pin_store,pins_board_url)
S3method(pin_version_delete,pins_board)
S3method(pin_version_delete,pins_board_azure)
S3method(pin_version_delete,pins_board_connect)
S3method(pin_version_delete,pins_board_databricks)
S3method(pin_version_delete,pins_board_folder)
S3method(pin_version_delete,pins_board_gcs)
S3method(pin_version_delete,pins_board_gdrive)
Expand All @@ -135,6 +143,7 @@ S3method(pin_version_delete,pins_board_url)
S3method(pin_versions,pins_board)
S3method(pin_versions,pins_board_azure)
S3method(pin_versions,pins_board_connect)
S3method(pin_versions,pins_board_databricks)
S3method(pin_versions,pins_board_folder)
S3method(pin_versions,pins_board_gcs)
S3method(pin_versions,pins_board_gdrive)
Expand All @@ -149,6 +158,7 @@ S3method(print,pins_meta)
S3method(required_pkgs,pins_board)
S3method(required_pkgs,pins_board_azure)
S3method(required_pkgs,pins_board_connect)
S3method(required_pkgs,pins_board_databricks)
S3method(required_pkgs,pins_board_gcs)
S3method(required_pkgs,pins_board_gdrive)
S3method(required_pkgs,pins_board_ms365)
Expand All @@ -166,6 +176,7 @@ export(board_browse)
export(board_cache_path)
export(board_connect)
export(board_connect_url)
export(board_databricks)
export(board_default)
export(board_deparse)
export(board_deregister)
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

## Other improvements

* Added new board for Databricks Volumes `board_databricks()` (#839, @edgararuiz).

* Added example Python code to pin previews for Posit Connect (#806).

* Fixed a bug in how pins with the same name but different owners on Posit Connect were identified (#808).
Expand Down
Loading
Loading