Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax activesupport dependency to support rails 8 #402

Conversation

drobny
Copy link
Contributor

@drobny drobny commented Nov 8, 2024

In addition, upgrade the GH actions checkout dependency to the latest so it runs on supported version of node

This resolves some deprecations checkout being run on a
deprecated node version
@michaelklishin
Copy link
Member

@drobny thank you. I am not dogmatic about how many unrelated changes would be acceptable for a PR but in general, I'd recommend upgrading actions independently from, say, library dependencies.

But this PR can go in as is.

@michaelklishin michaelklishin merged commit fb316d1 into ruby-amqp:main Nov 8, 2024
6 checks passed
@michaelklishin
Copy link
Member

@drobny I assume it would be a good idea to produce a new patch release soon to allow for easier adoption of Hutch with new Ruby on Rails versions. Am I correct?

@drobny
Copy link
Contributor Author

drobny commented Nov 8, 2024

@drobny I assume it would be a good idea to produce a new patch release soon to allow for easier adoption of Hutch with new Ruby on Rails versions. Am I correct?

Yes I think that would be ideal 👍 Thanks again for your swift review and ongoing maintenance of hutch 😄

@michaelklishin
Copy link
Member

@drobny understood. You should have a new version up on RubyGems by Monday :) Have a good one and thank you for contributing!

@michaelklishin michaelklishin added this to the 1.3.0 milestone Nov 11, 2024
@michaelklishin
Copy link
Member

Done.

@drobny drobny deleted the relax-activesupport-dependency-to-support-rails-8 branch November 12, 2024 09:43
drobny added a commit to drobny/hutch that referenced this pull request Dec 11, 2024
With the release of Rails 8.0.0.1 the dependency update I made as
part of ruby-amqp#402 is too strict
and the gem gets downgraded to version 0.23.1.

It might be better to remove the upper ceiling on `activesupport`
so this doesn't become a recurring blocker for future rails
releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants