Global minorversion #518
Global minorversion #518
Conversation
lib/quickbooks/service/customer.rb
Outdated
| @@ -9,17 +9,16 @@ def delete(customer) | |||
|
|
|||
| def url_for_resource(resource) | |||
| url = super(resource) | |||
| "#{url}?minorversion=#{Quickbooks::Model::Customer::MINORVERSION}" | |||
| url | |||
| end | |||
There was a problem hiding this comment.
this one seems like it could go too right?
lib/quickbooks/service/invoice.rb
Outdated
| @@ -7,17 +7,16 @@ def delete(invoice) | |||
| end | |||
|
|
|||
| def url_for_resource(resource) | |||
| url = super(resource) | |||
| super(resource) | |||
lib/quickbooks/service/invoice.rb
Outdated
| fetch_object(model, url, params) | ||
| end | ||
|
|
||
| def url_for_query(query = nil, start_position = 1, max_results = 20, options = {}) | ||
| url = super(query, start_position, max_results, options) | ||
| "#{url}&minorversion=#{Quickbooks::Model::Invoice::MINORVERSION}" | ||
| super(query, start_position, max_results, options) |
lib/quickbooks/service/customer.rb
Outdated
| fetch_object(model, url, params) | ||
| end | ||
|
|
||
| def url_for_query(query = nil, start_position = 1, max_results = 20, options = {}) | ||
| url = super(query, start_position, max_results, options) | ||
| "#{url}&minorversion=#{Quickbooks::Model::Customer::MINORVERSION}" | ||
| super(query, start_position, max_results, options) |
|
Do we have to worry about setting the global version introducing breaking changes? Like if I'm upgrading do I want to lock this at a lower version? |
Good question, I wondered about that too. From what I can tell QBO uses minorversions on data reads, potentially returning more info than before. I have yet to see if alter the format / payload depending on a version change. In other words, bumping the minorversion tells QBO to return additional data than before (e.g. Thus, I think it should be safe to use and not introduce backwards incompatibilities? |
|
That makes sense. It kind of an interesting versioning strategy if only adds additions. Typically versions are used to introduce breaking changes... so glad they haven't had to do that I guess? |
No description provided.