Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stringifying session ID for airship #3896

Merged
merged 10 commits into from
Nov 21, 2024
Merged

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Nov 21, 2024

What are the changes introduced in this PR?

We solved the uuid formatting problem for session ID in another task. But as mobile SDKs send the session ID as a number, isDefinedAndNotNullAndNotEmpty(1732129099) was returning false, so the UUID is not being calculated only.

What is the related Linear task?

Resolves INT-2948

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 requested review from a team and sivashanmukh as code owners November 21, 2024 04:27
@shrouti1507 shrouti1507 requested review from koladilip and sandeepdsvs and removed request for a team November 21, 2024 04:27
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.66%. Comparing base (f580f20) to head (795a5d3).
Report is 2 commits behind head on hotfix/21.11.

Files with missing lines Patch % Lines
src/v0/util/index.js 16.66% 8 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (f580f20) and HEAD (795a5d3). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f580f20) HEAD (795a5d3)
2 1
Additional details and impacted files
@@                Coverage Diff                @@
##           hotfix/21.11    #3896       +/-   ##
=================================================
- Coverage         90.47%   54.66%   -35.82%     
=================================================
  Files               616       63      -553     
  Lines             32311     3772    -28539     
  Branches           7675     1019     -6656     
=================================================
- Hits              29234     2062    -27172     
+ Misses             2853     1392     -1461     
- Partials            224      318       +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

sonarcloud bot commented Nov 21, 2024

@shrouti1507 shrouti1507 merged commit bb0b9dc into hotfix/21.11 Nov 21, 2024
20 of 21 checks passed
@shrouti1507 shrouti1507 deleted the fix.sessionid branch November 21, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants