Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stringifying session ID for airship #3896

Merged
merged 10 commits into from
Nov 21, 2024

fix: code review addressed

795a5d3
Select commit
Loading
Failed to load commit list.
Merged

fix: stringifying session ID for airship #3896

fix: code review addressed
795a5d3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 21, 2024 in 0s

54.66% (-35.82%) compared to f580f20

View this Pull Request on Codecov

54.66% (-35.82%) compared to f580f20

Details

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.66%. Comparing base (f580f20) to head (795a5d3).
Report is 1 commits behind head on hotfix/21.11.

Files with missing lines Patch % Lines
src/v0/util/index.js 16.66% 8 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (f580f20) and HEAD (795a5d3). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f580f20) HEAD (795a5d3)
2 1
Additional details and impacted files
@@                Coverage Diff                @@
##           hotfix/21.11    #3896       +/-   ##
=================================================
- Coverage         90.47%   54.66%   -35.82%     
=================================================
  Files               616       63      -553     
  Lines             32311     3772    -28539     
  Branches           7675     1019     -6656     
=================================================
- Hits              29234     2062    -27172     
+ Misses             2853     1392     -1461     
- Partials            224      318       +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: