Fix: Enable Usage of Local LLM in ChatEngine when chat_mode = context #11444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
| @@ -69,6 +69,7 @@ def from_defaults( | |||
| prefix_messages: Optional[List[ChatMessage]] = None, | |||
| node_postprocessors: Optional[List[BaseNodePostprocessor]] = None, | |||
| context_template: Optional[str] = None, | |||
| llm: Optional[LLM] = None, | |||
There was a problem hiding this comment.
below, we should also add llm = llm or llm_from_settings_or_context(...)
There was a problem hiding this comment.
Good catch, thanks!
logan-markewich
approved these changes
Feb 28, 2024
Dominastorm
pushed a commit
to uptrain-ai/llama_index
that referenced
this pull request
Feb 28, 2024
…run-llama#11444) * Add initialization of llm parameter to None in ContextChatEngine constructor * Refactor llm initialization
anoopshrma
pushed a commit
to anoopshrma/llama_index
that referenced
this pull request
Mar 2, 2024
…run-llama#11444) * Add initialization of llm parameter to None in ContextChatEngine constructor * Refactor llm initialization
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
…run-llama#11444) * Add initialization of llm parameter to None in ContextChatEngine constructor * Refactor llm initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an optional llm parameter with a default value of None to the ContextChatEngine constructor in context.py. This enhancement allows for the utilization of various LLMs instead of solely relying on the default OpenAI LLM.
Changes:
Introduced llm: Optional[LLM] = None parameter to the ContextChatEngine constructor in context.py.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods