Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Enable Usage of Local LLM in ChatEngine when chat_mode = context #11444

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix: Enable Usage of Local LLM in ChatEngine when chat_mode = context #11444

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74f1d5a
Add initialization of llm parameter to None in ContextChatEngine cons…
Thomas-AH-Heller Feb 27, 2024
8c0d6a0
Refactor llm initialization
Thomas-AH-Heller Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llama-index-core/llama_index/core/chat_engine/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def from_defaults(
prefix_messages: Optional[List[ChatMessage]] = None,
node_postprocessors: Optional[List[BaseNodePostprocessor]] = None,
context_template: Optional[str] = None,
llm: Optional[LLM] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

below, we should also add llm = llm or llm_from_settings_or_context(...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

**kwargs: Any,
) -> "ContextChatEngine":
"""Initialize a ContextChatEngine from default parameters."""
Expand Down
Loading