Add new useless_concat lint
#13829
Add new useless_concat lint
#13829
Conversation
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
useless-concat
branch
2 times, most recently
from
4918abc to
b92d91b
Compare
|
Finally was able to only trigger the lint when appropriate. |
|
r? clippy |
clippy_lints/src/useless_concat.rs
Outdated
| // Get the direct parent of the expression. | ||
| && let Some(macro_call) = macro_backtrace(expr.span).next() | ||
| // Check if the `concat` macro from the `core` library. | ||
| && match_def_path(cx, macro_call.def_id, &["core", "macros", "builtin", "concat"]) |
There was a problem hiding this comment.
Nit: can you move this path to clippy_utils::paths? Better to have the hardcoded paths in one place so we can every once in a while go through them and make them diagnostic items
There was a problem hiding this comment.
Didn't know about it, thanks for the tip!
clippy_lints/src/useless_concat.rs
Outdated
| /// ``` | ||
| #[clippy::version = "1.85.0"] | ||
| pub USELESS_CONCAT, | ||
| suspicious, |
There was a problem hiding this comment.
| suspicious, | |
| complexity, |
Since it just simplifies an expression and concat! isn't wrong to use, complexity feels more correct
clippy_lints/src/useless_concat.rs
Outdated
| if literal.is_some() { | ||
| return; | ||
| } | ||
| literal = Some(&original_code[current_pos..current_pos + token.len as usize]); |
There was a problem hiding this comment.
concat!(1) currently has 1 as the suggestion but it needs to be "1" with quotes to preserve the right type
There was a problem hiding this comment.
Good catch, gonna fix this case and add a regression test.
clippy_lints/src/useless_concat.rs
Outdated
| { | ||
| let mut literal = None; | ||
| let mut current_pos = 0; | ||
| let mut cursor = Cursor::new(&original_code); |
There was a problem hiding this comment.
Nit: can this use tokenize_with_text? It also gives access to the string, so that feels like it could simplify some parts like keeping track of positions
There was a problem hiding this comment.
Didn't know about this API either, quite convenient, thanks!
GuillaumeGomez
force-pushed
the
useless-concat
branch
from
b92d91b to
1b635c0
Compare
GuillaumeGomez
force-pushed
the
useless-concat
branch
from
1b635c0 to
87b000c
Compare
GuillaumeGomez
force-pushed
the
useless-concat
branch
from
87b000c to
8e6092c
Compare
|
Fixed dogfood. :) |
Fixes #13793.
Interestingly enough, to actually check that the macro call has at least two arguments, we need to use the rust lexer after getting the original source code snippet.
changelog: Add new
useless_concatlint