Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GameActivity PATCH: Don't read unicode via getUnicodeChar #106

Merged
merged 1 commit into from
Aug 7, 2023
Merged

GameActivity PATCH: Don't read unicode via getUnicodeChar #106

merged 1 commit into from
Aug 7, 2023

Commits on Aug 7, 2023

  1. GameActivity PATCH: Don't read unicode via getUnicodeChar 

    The `unicodeChar` in `GameActivityKeyEvent` wasn't being exposed by
`android-activity` because we couldn't expose the unicode character in
the same way with the native-activity backend - due to how events are
received via an `InputQueue` that doesn't expose the underlying Java
references for the key events.

Now that we have a consistent way of supporting unicode character
mapping via `KeyCharacterMap` bindings it's redundant for the
`GameActivity` backend to call `getUnicodeChar` automatically for
each key press.
    @rib
    rib committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    6b33074 View commit details
    Browse the repository at this point in the history