Fix lints/tests on nightly and unpin the CI nightly version #1703
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-unpin-night
branch
2 times, most recently
from
e99d4be to
6052ec9
Compare
nicholasbishop
changed the title
nicholasbishop
force-pushed
the
bishop-unpin-night
branch
from
6052ec9 to
9d889a2
Compare
These tests are sensitive to compiler version, and sometimes the output on nightly doesn't match the stable toolchain.
This (partially) reverts commit bdd3650.
nicholasbishop
force-pushed
the
bishop-unpin-night
branch
from
9d889a2 to
e24491f
Compare
phip1611
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mismatched-lifetime-syntaxes..github/workflows/nightly_toolchain.tomlCloses #1687
Checklist