-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Nonstatic Zip & Reqwest #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine for me, thanks for this!
I’d be a bit more cautious concerning the compression algorithm support. We use zip to read files generated by others. No problem for rust-tls |
Update: I patched zip to use only Rust versions of bzip2 and zstd, thereby allowing rustc to compile this lib statically |
We cannot depend directly on a git dependency, we need something properly published on crates.io By curiosity, would do you need this? |
I am waiting on an upstream PR with zip. Also, I do need this so I can run this in a container. |
I completely agree with this. |
|
@Tristramg Are you sure we need support for bzip and zstd? I did a compression method check on Transitland's database and it looks like they don't have a single file with bzip or zstd. |
I patched it to allow disabling of bzip and zstd via a feature, this shouldn't break anything by default since the feature is enabled by default: dkter@cf41895 If needed I can make another PR |
Can you make another PR for this? That would be great. Also, what do you intend on doing for rust-tls? |
I'm able to use default-tls for my use case but could re-export these if helpful?
|
Yeah, that looks good! Thanks. Let me know when you have the PR done so I can close this one. |
This does not affect the functionality of the crate, as this does not use zstd. Same thing with using rust-tls. We are just switching tls libraries.
These changes will allow a static compile of this library.