-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add hooks #1218
base: main
Are you sure you want to change the base?
feat: Add hooks #1218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this feature deserves:
- an integration test in some way
- a page in the cargo book docs
50d670e
to
720307a
Compare
rustic_backend = { git = "https://github.com/rustic-rs/rustic_core.git", features = ["cli"] } | ||
rustic_core = { git = "https://github.com/rustic-rs/rustic_core.git", features = ["cli"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may want to release the changes first without re-introducing git dependencies again, changing them back later. Now that releasing should be just merging the release pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we wait for a release of rustic_core, we'll pile up PRs in rustic which depend on these things but cannot be merged. We won't have the features in the nightly builds and will not get any feedback until we release a rustic release.
As many changes in rustic are changes in rustic_core, I see no alternative than using a git dependency here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I understand. Do you think it would be viable to up the release cadence for rustic_core
and say we do at least one release in a week with things that have been merged, even if small one's? It would be just a click away, we could release another rustic_core
version today, for example.
This PR adds
run-before
,run-after
,run-failure
andrun-finally
hooks for:[global]
config profile sectionbackup
command specifically in the[backup]
config profile section[[backup.sources]]
sectionNote: This PR includes only calling the given commands. If there is the wish for supplying information to the commands (env variables or parameter substitution), this should be covered by a separate feature request/PR.
closes #902