Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add hooks #1218

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+445 −196
Open

feat: Add hooks #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b9e2263
fix: return exitcode
aawsome Sep 2, 2024
9360397
feat: Add run-before and run-after hooks
aawsome Aug 30, 2024
e2ae782
dprint
aawsome Aug 30, 2024
664361c
Use new type CommandInput
aawsome Aug 31, 2024
aa56f13
add more hooks
aawsome Aug 31, 2024
36282a1
depend on rustic_core branch commandinput
aawsome Sep 2, 2024
720307a
add docu, examples and tests
aawsome Sep 2, 2024
261e9d1
Merge branch 'main'
aawsome Sep 13, 2024
45c9159
adapt to rustic_core
aawsome Sep 17, 2024
47b1950
update deps
aawsome Sep 18, 2024
d5f7cb4
Merge branch 'main'
aawsome Sep 18, 2024
473ce7c
use hooks for targets in copy command
aawsome Sep 19, 2024
f311a17
remove no longer needed dep
aawsome Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
159 changes: 99 additions & 60 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ rustdoc-args = ["--document-private-items", "--generate-link-to-definition"]

[dependencies]
abscissa_core = { version = "0.7.0", default-features = false, features = ["application"] }
rustic_backend = { version = "0.2.1", features = ["cli"] }
rustic_core = { version = "0.3.1", features = ["cli"] }
rustic_backend = { git = "https://github.com/rustic-rs/rustic_core.git", features = ["cli"] }
rustic_core = { git = "https://github.com/rustic-rs/rustic_core.git", features = ["cli"] }
Comment on lines +44 to +45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may want to release the changes first without re-introducing git dependencies again, changing them back later. Now that releasing should be just merging the release pr.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we wait for a release of rustic_core, we'll pile up PRs in rustic which depend on these things but cannot be merged. We won't have the features in the nightly builds and will not get any feedback until we release a rustic release.

As many changes in rustic are changes in rustic_core, I see no alternative than using a git dependency here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I understand. Do you think it would be viable to up the release cadence for rustic_core and say we do at least one release in a week with things that have been merged, even if small one's? It would be just a click away, we could release another rustic_core version today, for example.


# allocators
jemallocator-global = { version = "0.3.2", optional = true }
Expand Down
Loading
Loading