Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tooltip to advanced details #2153

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

iamacook
Copy link
Member

What it solves

Resolves unclear advanced details.

How this PR fixes it

This adds a tooltip next to the advanced details in the transaction flow.

How to test it

Create a transaction and open the details. Observe the new tooltip.

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Jun 22, 2023
@github-actions
Copy link

github-actions bot commented Jun 22, 2023

Branch preview

⏳ Deploying a preview site...

@github-actions
Copy link

github-actions bot commented Jun 22, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Not sure about the wording though, and I would align it to the right, not top. That's an Anisichtssache though.

@usame-algan
Copy link
Member

Would Don't edit these values if you are unsure also work? Sounds a bit more active to me.

@iamacook
Copy link
Member Author

Looks good! Not sure about the wording though, and I would align it to the right, not top. That's an Anisichtssache though.

As per our discussion, I've updated the wording accordingly:

image

@iamacook iamacook merged commit a378007 into epic-tx-flow Jun 22, 2023
@iamacook iamacook deleted the advanced-details-tooltip branch June 22, 2023 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants