Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tooltip to advanced details #2153

Merged
merged 2 commits into from
Jun 22, 2023
Merged

feat: add tooltip to advanced details #2153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a7974b
feat: add tooltip to advanced details
iamacook Jun 22, 2023
25f36ea
fix: alter wording
iamacook Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 40 additions & 2 deletions src/components/tx/DecodedTx/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
import { type SyntheticEvent, type ReactElement, useMemo } from 'react'
import { Accordion, AccordionDetails, AccordionSummary, Box, Skeleton, Typography } from '@mui/material'
import {
Accordion,
AccordionDetails,
AccordionSummary,
Box,
Skeleton,
SvgIcon,
Tooltip,
Typography,
} from '@mui/material'
import { OperationType, type SafeTransaction } from '@safe-global/safe-core-sdk-types'
import {
type DecodedDataResponse,
Expand All @@ -19,6 +28,9 @@ import ApprovalEditor from '@/components/tx/ApprovalEditor'
import { ErrorBoundary } from '@sentry/react'
import { getNativeTransferData } from '@/services/tx/tokenTransferParams'
import Multisend from '@/components/transactions/TxDetails/TxData/DecodedData/Multisend'
import InfoIcon from '@/public/images/notifications/info.svg'
import ExternalLink from '@/components/common/ExternalLink'
import { HelpCenterArticle } from '@/config/constants'

type DecodedTxProps = {
tx?: SafeTransaction
Expand Down Expand Up @@ -97,8 +109,34 @@ const DecodedTx = ({ tx, txId }: DecodedTxProps): ReactElement | null => {
)}

<Box mt={2}>
<Typography variant="overline" fontWeight="bold" color="border.main">
<Typography variant="overline" fontWeight="bold" color="border.main" display="flex" alignItems="center">
Advanced details
<Tooltip
title={
<>
We recommend not changing the default values unless necessary.{' '}
<ExternalLink href={HelpCenterArticle.ADVANCED_PARAMS} title="Learn more about advanced details">
Learn more about advanced details
</ExternalLink>
.
</>
}
arrow
placement="top"
>
<span>
<SvgIcon
component={InfoIcon}
inheritViewBox
color="border"
fontSize="small"
sx={{
verticalAlign: 'middle',
ml: 0.5,
}}
/>
</span>
</Tooltip>
</Typography>

{txDetails ? <Summary txDetails={txDetails} defaultExpanded /> : tx && <PartialSummary safeTx={tx} />}
Expand Down