chore: Analyze NextJS bundle size action #2803
Conversation
Branch preview✅ Deploy successful! https://bundle_analyzer--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Test suite run success1105 tests passing in 155 suites. Report generated by 🧪jest coverage report action from f913961 |
usame-algan
force-pushed
the
bundle-analyzer
branch
from
e832821
to
bcff8d0
Compare
| push: | ||
| branches: | ||
| - dev |
There was a problem hiding this comment.
According to the template this should be the default branch which is dev for us so it can compare bundle sizes with dev later on.
| defaults: | ||
| run: | ||
| # change this if your nextjs app does not live at the root of the repo | ||
| working-directory: ./ |
There was a problem hiding this comment.
Yes, and I think its correct since the generated artifact includes all our routes and the global chunk size: https://github.com/safe-global/safe-wallet-web/actions/runs/6853583646
There was a problem hiding this comment.
I mean, you don't need to specify it as per the comment above.
There was a problem hiding this comment.
Ah ok, I will try to remove it completely and see if it works.
There was a problem hiding this comment.
Still works as expected 👍
| - name: Restore next build | ||
| uses: actions/cache@v3 | ||
| id: restore-build-cache | ||
| env: | ||
| cache-name: cache-next-build | ||
| with: | ||
| # if you use a custom build directory, replace all instances of `.next` in this file with your build directory | ||
| # ex: if your app builds to `dist`, replace `.next` with `dist` | ||
| path: .next/cache | ||
| # change this if you prefer a more strict cache | ||
| key: ${{ runner.os }}-build-${{ env.cache-name }} |
There was a problem hiding this comment.
This should probably be in the build job in workflows/build?
There was a problem hiding this comment.
I think we can remove this part since our ./.github/workflows/yarn already caches the result.
What it solves
Resolves #2802
How this PR fixes it
Adds a new action to analyze bundle size changes of the nextjs app