-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Analyze NextJS bundle size action #2803
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
# Copyright (c) HashiCorp, Inc. | ||
# SPDX-License-Identifier: MPL-2.0 | ||
|
||
name: 'Next.js Bundle Analysis' | ||
|
||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
- dev | ||
|
||
permissions: | ||
contents: read # for checkout repository | ||
actions: read # for fetching base branch bundle stats | ||
pull-requests: write # for comments | ||
|
||
jobs: | ||
analyze: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Install dependencies | ||
uses: ./.github/workflows/yarn | ||
|
||
- name: Build next.js app | ||
uses: ./.github/workflows/build | ||
with: | ||
secrets: ${{ toJSON(secrets) }} | ||
|
||
# Here's the first place where next-bundle-analysis' own script is used | ||
# This step pulls the raw bundle stats for the current bundle | ||
- name: Analyze bundle | ||
run: npx -p nextjs-bundle-analysis report | ||
|
||
- name: Upload bundle | ||
uses: actions/upload-artifact@v3 | ||
with: | ||
name: bundle | ||
path: .next/analyze/__bundle_analysis.json | ||
|
||
- name: Download base branch bundle stats | ||
uses: dawidd6/action-download-artifact@v2 | ||
if: success() && github.event.number | ||
with: | ||
workflow: nextjs_bundle_analysis.yml | ||
branch: ${{ github.event.pull_request.base.ref }} | ||
path: .next/analyze/base | ||
|
||
# And here's the second place - this runs after we have both the current and | ||
# base branch bundle stats, and will compare them to determine what changed. | ||
# There are two configurable arguments that come from package.json: | ||
# | ||
# - budget: optional, set a budget (bytes) against which size changes are measured | ||
# it's set to 350kb here by default, as informed by the following piece: | ||
# https://infrequently.org/2021/03/the-performance-inequality-gap/ | ||
# | ||
# - red-status-percentage: sets the percent size increase where you get a red | ||
# status indicator, defaults to 20% | ||
# | ||
# Either of these arguments can be changed or removed by editing the `nextBundleAnalysis` | ||
# entry in your package.json file. | ||
- name: Compare with base branch bundle | ||
if: success() && github.event.number | ||
run: ls -laR .next/analyze/base && npx -p nextjs-bundle-analysis compare | ||
|
||
- name: Get Comment Body | ||
id: get-comment-body | ||
if: success() && github.event.number | ||
# https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings | ||
run: | | ||
echo "body<<EOF" >> $GITHUB_OUTPUT | ||
echo "$(cat .next/analyze/__bundle_analysis_comment.txt)" >> $GITHUB_OUTPUT | ||
echo EOF >> $GITHUB_OUTPUT | ||
|
||
- name: Find Comment | ||
uses: peter-evans/find-comment@v2 | ||
if: success() && github.event.number | ||
id: fc | ||
with: | ||
issue-number: ${{ github.event.number }} | ||
body-includes: '<!-- __NEXTJS_BUNDLE -->' | ||
|
||
- name: Create Comment | ||
uses: peter-evans/create-or-update-comment@v2 | ||
if: success() && github.event.number && steps.fc.outputs.comment-id == 0 | ||
with: | ||
issue-number: ${{ github.event.number }} | ||
body: ${{ steps.get-comment-body.outputs.body }} | ||
|
||
- name: Update Comment | ||
uses: peter-evans/create-or-update-comment@v2 | ||
if: success() && github.event.number && steps.fc.outputs.comment-id != 0 | ||
with: | ||
issue-number: ${{ github.event.number }} | ||
body: ${{ steps.get-comment-body.outputs.body }} | ||
comment-id: ${{ steps.fc.outputs.comment-id }} | ||
edit-mode: replace |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the template this should be the default branch which is dev for us so it can compare bundle sizes with dev later on.