Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce MFA for all accounts #59

Merged
merged 23 commits into from
Feb 13, 2025
Merged

enforce MFA for all accounts #59

merged 23 commits into from
Feb 13, 2025

Conversation

nathanstitt
Copy link
Member

Redirects to /account/mfa whenever a user without mfa enabled uses SI

image image

Redirects to /account/mfa whenever a user without mfa enabled uses SI
package.json Outdated Show resolved Hide resolved
types/globals.d.ts Outdated Show resolved Hide resolved
src/app/account/mfa/sms/page.tsx Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 12, 2025

Coverage Report

Name Coverage % Covered Uncovered Total
Bytes 🟡 76.83 % 56,078 16,911 72,989
Statements 🟡 66.23 % 451 230 681
Branches 🔴 44.64 % 100 124 224
Functions 🟡 59.06 % 101 70 171
Lines 🟡 72.85 % 1,350 503 1,853

@nathanstitt nathanstitt force-pushed the enforce-mfa branch 2 times, most recently from 843e2fa to 82790eb Compare February 12, 2025 19:41
Copy link
Contributor

@chrisbendel chrisbendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!! nice work

@chrisbendel
Copy link
Contributor

@nathanstitt i handled the merge conflict from merging #53 upstream in this commit let me know if this looks good to you

@chrisbendel chrisbendel merged commit 2f46705 into main Feb 13, 2025
1 check passed
@chrisbendel chrisbendel deleted the enforce-mfa branch February 13, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants