Rewrite IpyWidgets Renderer/Manager to use latest version of ipywidgets and ideas/code from the open source colab cdn widget manager #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, model not defined (due to restarting project, say)
- which I recently caused when polishing the styles
…before -- hopefully this is needed...
- use katex by default (which falls back to mathjax) - is thus MUCH faster - add extra spacing so not all smooshed like upstream is (why?)
- super annoying for sage 3d graphics...
…n't sanitized if notebook is trusted
…s get "messed up/deleted"
…ized v deserialized
- how was this still broken? anyway, finally fixed!
…of references *to* things in dom, e.g., jsdlink
…is makes it mpld3 works
…ustom messages from backend to frontend
… approach is clearly greatly superior and will work. - I'm also really tired of fixing the old code whenever I change the new code, since that is a waste of time.
…done *before* model creation
- with file upload this works, then is immediately overwritten by empty data, thus breaking it. So not done yet.
… upload widget works!
…s state help function - this k3d locking is needed to workaround k3d implementing their own internal custom references, and just assuming everything is created in exactly the order it is in jupyterlab. With RTC the order can be more random, so we manually enforce it.
…vers fully work too. - NOTE: we'll benchmark and maybe use http for non-compute servers; not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix every open ipywidgets issue in CoCalc, AND preserver realtime collaboration for widgets, thus potentially giving CoCalc by far the best ipywidgets client in the world. We shall see.