SAK-50560 Samigo fix matching feedback display to student when instru… #12943
Conversation
…ctor does not release student answer
| </h:graphicImage> | ||
| <h:column rendered="#{delivery.feedback eq 'true' && delivery.feedbackComponent.showCorrectResponse && !delivery.noFeedback=='true'}"> | ||
| <h:panelGroup id="image" rendered="#{matching.isCorrect eq 'true'}" styleClass="si si-check-lg" > </h:panelGroup> | ||
| <h:panelGroup id="ximage" rendered="#{not empty matching.isCorrect && matching.isCorrect eq 'false'}" styleClass="si si-remove feedBackCross"> </h:panelGroup> |
There was a problem hiding this comment.
i guess matching.isCorrect eq 'false' is all that is needed right @ern? it is a Boolean behind the scenes so it can be null
There was a problem hiding this comment.
I think if it's a Boolean and not a boolean you may have a not empty matching.isCorrect on both of these conditions to avoid an NPE? I'm not too sure about JSF.
There was a problem hiding this comment.
no doesn't seem to NPE
the root of the problem seems to be this: !matching.isCorrect which seems to match null and false
samigo/samigo-app/src/webapp/jsf/delivery/item/deliverMatching.jsp
Outdated
Show resolved
Hide resolved
| width="16" height="16" | ||
| alt="#{deliveryMessages.alt_incorrect}" url="/images/delivery/spacer.gif"> | ||
| </h:graphicImage> | ||
| <h:column rendered="#{delivery.feedback eq 'true' && delivery.feedbackComponent.showCorrectResponse && !delivery.noFeedback=='true'}"> |
There was a problem hiding this comment.
I'm not sure if it's another issue but it seems like this should also be && delivery.noFeedback ne 'true' to be consistent with the delivery.feedback? Maybe this isn't a bug though but using eq and == doesn't seem correct.
There was a problem hiding this comment.
yes the mixing is puzzling! plus might as well be consistent and make delivery.feedbackComponent.showCorrectResponse eq 'true' also!
samigo/samigo-app/src/webapp/jsf/delivery/item/deliverMatching.jsp
Outdated
Show resolved
Hide resolved
|
thanks @jonespm i revised per comments |
…ctor does not release student answer