Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for unknown onEnd engagement action #1208

Conversation

ykyivskyi-gl
Copy link
Contributor

What was solved?
This PR adds logs for unknown onEnd engagement action

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the log is managed dependency, it would be probably not very hard to add unit test for case let .unknown(unhandledCase). Does it make sense?

@ykyivskyi-gl
Copy link
Contributor Author

!squash

@sm-deployer sm-deployer force-pushed the MOB-3971-add-logs-for-unknown-on-end-action branch from 21743d0 to 1cbee5e Compare January 31, 2025 15:36
@ykyivskyi-gl
Copy link
Contributor Author

@igorkravchenko I am not a big fan of testing logs but I think you are right in this case, it makes sense to cover unknown enum cases logs with tests. Thanks!

@ykyivskyi-gl ykyivskyi-gl merged commit 2d5c1d0 into feature/entry-widget-and-secure-conversations-v2 Feb 3, 2025
8 checks passed
@ykyivskyi-gl ykyivskyi-gl deleted the MOB-3971-add-logs-for-unknown-on-end-action branch February 3, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants