Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for unknown onEnd engagement action #1208

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ extension ChatViewModel {
case .showEndedNotification:
handleOperatorEndedEngagement()
case let .unknown(unhandledCase):
// TODO: log unhandled case MOB-3971
environment.log.warning("Engagement ended with unknown case '\(unhandledCase)'.")
handleOperatorEndedEngagement()
@unknown default:
// TODO: log unhandled case MOB-3971
environment.log.warning("Engagement ended with unknown case.")
handleOperatorEndedEngagement()
}
// There's no need for nilling-out operator image in the bubble via
Expand Down
38 changes: 38 additions & 0 deletions GliaWidgetsTests/Sources/ChatViewModel/ChatViewModelTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,44 @@ class ChatViewModelTests: XCTestCase {
]
)
}

func test_engagementEndedByOperatorWithUnknownOnEndActionLogsWarning() {
var interactorEnv = Interactor.Environment.failing
interactorEnv.gcd.mainQueue = .mock
let interactor = Interactor.mock(environment: interactorEnv)
interactor.state = .ended(.byOperator)
var warnings: [String] = []
let mockUnknownAction = "Unknown reason"

var viewModelEnv = ChatViewModel.Environment.failing()
viewModelEnv.fileManager.urlsForDirectoryInDomainMask = { _, _ in [.mock] }
viewModelEnv.fileManager.createDirectoryAtUrlWithIntermediateDirectories = { _, _, _ in }
let fileUploadListViewModelEnv = SecureConversations.FileUploadListViewModel.Environment.mock
fileUploadListViewModelEnv.uploader.uploads = []
viewModelEnv.createFileUploadListModel = { _ in .mock(environment: fileUploadListViewModelEnv) }
viewModelEnv.log = .mock
viewModelEnv.log.warningClosure = { message, _, _, _ in
warnings.append("\(message)")
}
let viewModel = ChatViewModel.mock(interactor: interactor, environment: viewModelEnv)
enum Call {
case engagementActionShowAlertWithOperatorEndedEngagement
}
var calls: [Call] = []
viewModel.engagementAction = { action in
switch action {
case .showAlert(.operatorEndedEngagement):
calls.append(.engagementActionShowAlertWithOperatorEndedEngagement)
default:
break
}
}

interactor.setEndedEngagement(.mock(actionOnEnd: .unknown(mockUnknownAction)))
viewModel.interactorEvent(.stateChanged(.ended(.byOperator)))
XCTAssertEqual(calls, [.engagementActionShowAlertWithOperatorEndedEngagement])
XCTAssertEqual(warnings, ["Engagement ended with unknown case '\(mockUnknownAction)'."])
}

func test_closeActionDoesNotShowConfirmationIfThereIsTransferredSC() throws {
var interactorEnv = Interactor.Environment.failing
Expand Down
Loading