Updated Micro epsilon SDK and dependencies #32
Conversation
dave992
force-pushed
the
LH2-210-Update-SDK-version-micro-epsilon
branch
from
181cf91
to
8bcd331
Compare
.docker/Dockerfile
Outdated
| meson setup build && \ | ||
| cd build && \ | ||
| ninja && \ | ||
| checkinstall --pkgname aravis --pkgversion 0.8.30 --requires="libglib2.0-dev, libxml2-dev" ninja install |
There was a problem hiding this comment.
just curious why we 'bother' with checkinstall if this is a Dockerfile?
Format the dependencies as well
| pkg-config \ | ||
| unzip \ | ||
| wget \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
| xsltproc \ | ||
| && rm -rf /var/lib/apt/lists/* && \ |
There was a problem hiding this comment.
I'd suggest expanding this a bit further - this is the standard 'clean-up' stanza I use with each apt call:
apt-get autoremove -y &&\
apt-get clean -y &&\
rm -rf /var/lib/apt/lists/*
|
|
||
| FROM ros:melodic-ros-core | ||
| FROM ros:noetic-ros-core |
There was a problem hiding this comment.
I'd recommend that you add an AS label for FROM statements. It breaks the file up a bit conceptually, and makes multi-target builds an option (if we want to use them later).
There's an example on line 3.
| intltool \ | ||
| pkg-config \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| COPY --from=build ["/library_pkgs", "/library_pkgs"] | ||
|
|
||
| RUN apt-get update && \ | ||
| apt install -y /library_pkgs/aravis_0.6.4-1_amd64.deb && \ | ||
| apt install -y /library_pkgs/aravis_0.8.30-1_amd64.deb && \ |
There was a problem hiding this comment.
It's preferable to use apt-get rather than apt in scripts - it has a more reliable command line interface.
I think you can do all of the packages in one install command too (but please test it works if you change it).
Finally, if these are the only files in /library_pkgs/, then you could consider using
apt-get install /library_pkgs/* to make the command shorter. Obviously if there are additional files in there that you don't want, or the contents are subject to change, then don't do this. :)
…icro-epsilon Updated Micro epsilon SDK and dependencies (cherry picked from commit c91a7e5)
Update the driver and Dockerfile used for build testing to v1.0.0 of the SDK (currently the latest version) for the Micro Epsilon scanCONTROL devices.
Jira issue: LH2-210
Motivation and Context
The current SDK version (v0.2.5) is outdated and does not support the latest devices.
Changes
Type of changes
Checklist