-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ros2 devel resume #35
Conversation
Co-authored-by: G.A. vd. Hoorn <[email protected]>
Update dockerfile for scancontrol SDK version 0.2.5
.docker/Dockerfile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
high-level, first impression, comment: have we considered splitting this? Seems to build a nr of things, might be worthwhile to build the two dependency .deb
s in separate images, then use the results to build the actual driver image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not focusing on CI right now. This is mostly a placeholder PR.
I'd rather worry about having a successful CI for jammy right now, if you could help pls?
I can share the Dockerfile that works for my dev env, from there it should be esasy to optimize to CI
Changed to darft, if you want to solve all issues here, right now.
|
…icro-epsilon Updated Micro epsilon SDK and dependencies (cherry picked from commit c91a7e5)
Added temporary Dockerfile image on my personal dockerhub for CI |
Added LIC Apache2.0 properly |
@gavanderhoorn I know it's a big PR, but it is all WIP, can anyone accept it now so I can do more granular updates? Next steps. I will open separate issues for each, if we get this PR done pls:
|
First steps towards bringing into our main repo the past work from @dave992 @rtonnaer @NithishkumarS and @christianlandgraf
Cheers!