Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 devel resume #35

Merged
merged 23 commits into from
Feb 26, 2024
Merged

Ros2 devel resume #35

merged 23 commits into from
Feb 26, 2024

Conversation

Pugens
Copy link

@Pugens Pugens commented Feb 14, 2024

First steps towards bringing into our main repo the past work from @dave992 @rtonnaer @NithishkumarS and @christianlandgraf

  • The CI is failing, as latest ros2 is the taget
  • For now, only the description pakage is working as expected, with improvements needed yet
  • Dev setup can be shared on this branch as well if needed, but main points to get it to work are:
    • Changes done by @NithishkumarS here, namely move to scanCONTROL SDK 1.0.0 and Aravis 0.8
    • Suggestions by @erichlf to compile the SDK on Ubuntu 22, namely, the lltlib header file needs changing here

Cheers!

@Pugens Pugens added the enhancement New feature or request label Feb 14, 2024
@Pugens Pugens self-assigned this Feb 14, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high-level, first impression, comment: have we considered splitting this? Seems to build a nr of things, might be worthwhile to build the two dependency .debs in separate images, then use the results to build the actual driver image?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not focusing on CI right now. This is mostly a placeholder PR.
I'd rather worry about having a successful CI for jammy right now, if you could help pls?
I can share the Dockerfile that works for my dev env, from there it should be esasy to optimize to CI

@Pugens Pugens marked this pull request as draft February 14, 2024 12:50
@Pugens
Copy link
Author

Pugens commented Feb 14, 2024

Changed to darft, if you want to solve all issues here, right now.
But this is meant to be a WIP, a dev branch.
Stuff needed to do yet:

  • Fix CI
  • Fix driver pkg
  • Check msg if up to date with ROS2
  • Fix license, readme, etc
  • Share a dev env setup to work with?

…icro-epsilon

Updated Micro epsilon SDK and dependencies

(cherry picked from commit c91a7e5)
@Pugens
Copy link
Author

Pugens commented Feb 15, 2024

Added temporary Dockerfile image on my personal dockerhub for CI

@Pugens
Copy link
Author

Pugens commented Feb 15, 2024

Added LIC Apache2.0 properly

@Pugens
Copy link
Author

Pugens commented Feb 15, 2024

@gavanderhoorn I know it's a big PR, but it is all WIP, can anyone accept it now so I can do more granular updates?
Otherwise the diff will just increase.

Next steps. I will open separate issues for each, if we get this PR done pls:

  • Check intensity integration from @christianlandgraf
  • Fix tfs as the profile is not showing on rviz2 beacuse of some issues related to them
  • Improve reliability at connection/disconnection to avoid possible false/negligible error -1005 at connection (update firmware needed)
  • etc.. etc..

@Pugens Pugens linked an issue Feb 15, 2024 that may be closed by this pull request
@Pugens Pugens marked this pull request as ready for review February 16, 2024 10:54
@Pugens Pugens merged commit 12940b7 into sam-xl:ros2-devel Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROS2 support
4 participants