Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and fix all services #37

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Test and fix all services #37

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a962ee4
Fix ros2 port using node class
nikhil-sethi Oct 1, 2024
145e675
Remove test string for cleaning up PR
nikhil-sethi Oct 1, 2024
48b2462
Fix setResolution bug + response error codes
nikhil-sethi Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions micro_epsilon_scancontrol_driver/src/driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ namespace scancontrol_driver
this->get_parameter_or("resolution", config_.resolution, -1);

// Multiple device parameters
this->declare_parameter<std::string>("serial", std::string("MICRO-EPSILON Optronic GmbH-scanCONTROL 3060-25 -519080050"));
this->get_parameter_or("serial", config_.serial, std::string("MICRO-EPSILON Optronic GmbH-scanCONTROL 3060-25 -519080050"));
this->declare_parameter<std::string>("serial", std::string(""));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW: https://en.cppreference.com/w/cpp/string/basic_string/operator%22%22s

this->get_parameter_or("serial", config_.serial, std::string(""));
this->declare_parameter<std::string>("frame_id", std::string(DEFAULT_FRAME_ID));
this->get_parameter_or("frame_id", config_.frame_id, std::string(DEFAULT_FRAME_ID));
this->declare_parameter<std::string>("topic_name", std::string(DEFAULT_TOPIC_NAME));
Expand Down