Test and fix all services #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- service architecture works now
- used resolution argument instead of config - fix response error code logic
|
All services work, but set and get feature need different encodings for each specific feature. People can see the docs and add whatever they like. |
3 tasks
|
Fixed: #38 (comment) |
nikhil-sethi
added
bug
erichlf
reviewed
Oct 15, 2024
| @@ -16,8 +16,8 @@ namespace scancontrol_driver | |||
| this->get_parameter_or("resolution", config_.resolution, -1); | |||
|
|
|||
| // Multiple device parameters | |||
| this->declare_parameter<std::string>("serial", std::string("MICRO-EPSILON Optronic GmbH-scanCONTROL 3060-25 -519080050")); | |||
| this->get_parameter_or("serial", config_.serial, std::string("MICRO-EPSILON Optronic GmbH-scanCONTROL 3060-25 -519080050")); | |||
| this->declare_parameter<std::string>("serial", std::string("")); | |||
There was a problem hiding this comment.
erichlf
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch/PR will test and fix all services.
This is pretty much same as #36 but made separately to align with Jira tickets.
Depends on: #36
Services to test: