-
Notifications
You must be signed in to change notification settings - Fork 17
sambacc: use tempfile as arg to net conf import #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Flake8 failures CI/test (fedora-latest) seem to be unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks.
|
Oh, it's fedora 43. It just got released. |
|
#179 for a fix for the ci failure |
|
@Mergifyio rebase |
net conf import is unable to use the STDIN to import the configuration when the generated smb.conf is large. Use a tempfile instead as an argument to net conf import. Resolves: rhbz#2400102 Signed-off-by: Sachin Prabhu <[email protected]>
✅ Branch has been successfully rebased |
6decb5b to
c3b99ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with the changes although we are yet to root cause the real problem with net conf import via STDIN. Should we investigate after filing a bz?
The change looks good, but I think we should know why it fails. Specially because it's a silent failure, which is not good. |
|
Yes. I think this should be reported in a bz in samba upstream since that is where we have a bug. This problem could affect other users as well. For Ceph-SMB, I would say this is fixed and move on. |
net conf import is unable to use the STDIN to import the configuration when the generated smb.conf is large. Use a tempfile instead as an argument to net conf import.
Resolves: rhbz#2400102