Skip to content

sambacc: use tempfile as arg to net conf import #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

sambacc: use tempfile as arg to net conf import #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions sambacc/netcmd_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import subprocess
import typing
import tempfile

from sambacc import config
from sambacc import samba_cmds
Expand Down Expand Up @@ -56,10 +57,11 @@ def _check(self, cli: typing.Any, proc: subprocess.Popen) -> None:

def import_config(self, iconfig: config.InstanceConfig) -> None:
"""Import to entire instance config to samba config."""
cli, proc = self._cmd("import", "/dev/stdin", stdin=subprocess.PIPE)
template_config(proc.stdin, iconfig, enc=samba_cmds.encode)
proc.stdin.close()
self._check(cli, proc)
with tempfile.NamedTemporaryFile() as tf:
template_config(tf, iconfig, enc=samba_cmds.encode)
tf.flush()
cli, proc = self._cmd("import", tf.name)
self._check(cli, proc)

def dump(self, out: typing.IO) -> None:
"""Dump the current smb config in an smb.conf format.
Expand Down
Loading