Do not call signals.got_request_exception for expected exceptions. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subclasses of jsonrpc.exceptions.Error are used to return JSONRPC error responses in well defined situations and should not call the got_request_exception signal used for uncaught exceptions. This is similar to the behaviour of the Django Http404 exception.
samuraisam
added a commit
that referenced
this pull request
Nov 30, 2015
Do not call signals.got_request_exception for expected exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subclasses of jsonrpc.exceptions.Error are used to return JSONRPC error responses in well defined situations and should not call the got_request_exception signal used for uncaught exceptions.
This is similar to the behaviour of the Django Http404 exception.
This pull request is similar to #40 but without using a configuration option.