Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call signals.got_request_exception for expected exceptions. #75

Merged
merged 1 commit into from
Nov 30, 2015
Merged

Do not call signals.got_request_exception for expected exceptions. #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions jsonrpc/site.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,6 @@ def response_dict(self, request, D,
status = 200

except Error as e:
signals.got_request_exception.send(sender=self.__class__,
request=request)
response['error'] = e.json_rpc_format
if version in ('1.1', '2.0') and 'result' in response:
response.pop('result')
Expand Down Expand Up @@ -265,8 +263,6 @@ def dispatch(self, request, method='', json_encoder=None):

json_rpc = dumps(response, cls=json_encoder)
except Error as e:
signals.got_request_exception.send(sender=self.__class__,
request=request)
response['error'] = e.json_rpc_format
status = e.status
json_rpc = dumps(response, cls=json_encoder)
Expand Down