unnest endpoint_opts in tests to fix some ci failures #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Jun 19, 2024
| @@ -30,12 +30,10 @@ for {input, index} <- Enum.with_index(inputs), | |||
| setup_all do | |||
| start_supervised!({ | |||
| TestEndpoint, | |||
| endpoint_opts: [ | |||
There was a problem hiding this comment.
This caused opts to be
[
endpoint: SiteEncrypt.Phoenix.Endpoint.Cowboy2Adapter.NativeTest.TestEndpoint,
endpoint_opts: [
endpoint_opts: [
adapter: Phoenix.Endpoint.Cowboy2Adapter,
http: [port: 40000],
https: [port: 40001],
url: [scheme: "https", host: "localhost", port: 40001]
]
]
]There was a problem hiding this comment.
Not sure though if it's a test issue or a configuration issue.
There was a problem hiding this comment.
It was introduced in a680884. This only affected tests though.
|
The dialyzer error seems to be a bug in Elixir 1.17.0, fixed in 1.17.1 already. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix at least some of the failing tests. Comments inline.