Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnest endpoint_opts in tests to fix some ci failures #67

Merged
merged 2 commits into from
Jun 19, 2024
Merged

unnest endpoint_opts in tests to fix some ci failures #67

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
717c11e
unnest endpoint_opts in tests to fix some ci failures
ruslandoga Jun 19, 2024
9869f9f
update asdf versions and fix dialyzer
ruslandoga Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions test/site_encrypt_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,10 @@ for {input, index} <- Enum.with_index(inputs),
setup_all do
start_supervised!({
TestEndpoint,
endpoint_opts: [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused opts to be

[
  endpoint: SiteEncrypt.Phoenix.Endpoint.Cowboy2Adapter.NativeTest.TestEndpoint,
  endpoint_opts: [
    endpoint_opts: [
      adapter: Phoenix.Endpoint.Cowboy2Adapter,
      http: [port: 40000],
      https: [port: 40001],
      url: [scheme: "https", host: "localhost", port: 40001]
    ]
  ]
]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure though if it's a test issue or a configuration issue.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was introduced in a680884. This only affected tests though.

adapter: unquote(input.adapter),
http: [port: unquote(http_port)],
https: [port: unquote(https_port)],
url: [scheme: "https", host: "localhost", port: unquote(https_port)]
]
adapter: unquote(input.adapter),
http: [port: unquote(http_port)],
https: [port: unquote(https_port)],
url: [scheme: "https", host: "localhost", port: unquote(https_port)]
})

:ok
Expand Down
Loading