Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new options for @sasjs/lint #1384

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
13 changes: 6 additions & 7 deletions .github/SECURITY.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
# Security Policy

As an Enterprise tool, security is taken seriously by the SASjs team. In general we look to minimise third party dependencies, and we distinguish between production dependencies and development dependencies whenever possible.
As an Enterprise tool, security is taken seriously by the SASjs team. In general we look to minimise third party dependencies, and we distinguish between production dependencies and development dependencies whenever possible.

In addition we take the following steps:

* Use of Dependabot for automated reporting of security issues
* Locking versions to prevent upgrades unless explicitly applied
* We run `npm audit` as part of the CI build to ensure the dependency tree is clear from warnings
- Use of Dependabot for automated reporting of security issues.
- Locking versions to prevent upgrades unless explicitly applied.
- We run `npm run audit` as part of the CI build to ensure the dependency tree is clear from warnings. At the moment we ignore the reported Cross-Site Request Forgery vulnerability in Axios because it is mainly related to the browsers and it does not apply to @sasjs/cli.

## Supported Versions

We support only the latest version with security updates. If you would like an earlier version supported, then do [get in touch](https://sasapps.io/contact-us).
We support only the latest version with security updates. If you would like an earlier version supported, then do [get in touch](https://sasapps.io/contact-us).

## Reporting a Vulnerability

We welcome reponsible disclosures and will act immediately. Please report [here](https://sasapps.io/contact-us) with full details of the vulnerability.

We welcome reponsible disclosures and will act immediately. Please report [here](https://sasapps.io/contact-us) with full details of the vulnerability.
4 changes: 2 additions & 2 deletions .github/workflows/npmpublish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

strategy:
matrix:
node-version: [lts/hydrogen]
node-version: [lts/iron]

steps:
- name: Checkout
Expand All @@ -35,7 +35,7 @@ jobs:
run: npm run build

- name: Check npm audit
run: npm audit --omit=dev --audit-level=low
run: npm run audit

- name: Set NPM Registry back to https
run: npm config set registry https://registry.npmjs.org
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/run-tests-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [lts/hydrogen]
node-version: [lts/iron]

steps:
- uses: actions/checkout@v2
Expand All @@ -30,7 +30,7 @@ jobs:
- name: Install Doxygen
run: |
git clone https://github.com/sasjs/doxygen-installer.git
.\doxygen-installer\install.bat
.\doxygen-installer\install.bat -Force

- name: Add doxygen to path
run: echo "C:\Program Files\doxygen\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [lts/hydrogen]
node-version: [lts/iron]

steps:
- uses: actions/checkout@v2
Expand All @@ -24,7 +24,7 @@ jobs:
cache: npm

- name: Check npm audit
run: npm audit --production --audit-level=low
run: npm install -g better-npm-audit && npm run audit

- name: Install production dependencies (fail if any warning)
run: sh ./npm-production-install.sh
Expand Down
6 changes: 6 additions & 0 deletions .nsprc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"1097679": {
"active": true,
"notes": "Ignored since the Cross-Site Request Forgery vulnerability in Axios is mainly related to the browsers and it does not apply to @sasjs/cli."
}
}
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,9 @@
[![npm package][npm-image]][npm-url]
[![Github Workflow][githubworkflow-image]][githubworkflow-url]
[![npm](https://img.shields.io/npm/dt/@sasjs/cli)]()
![Snyk Vulnerabilities for npm package](https://img.shields.io/snyk/vulnerabilities/npm/@sasjs/cli)
[![License](https://img.shields.io/apm/l/atomic-design-ui.svg)](/LICENSE)
![GitHub top language](https://img.shields.io/github/languages/top/sasjs/cli)
[![GitHub closed issues](https://img.shields.io/github/issues-closed-raw/sasjs/cli)](https://github.com/sasjs/cli/issues?q=is%3Aissue+is%3Aclosed)
[![GitHub issues](https://img.shields.io/github/issues-raw/sasjs/cli)](https://github.com/sasjs/cli/issues)
[![Gitpod ready-to-code](https://img.shields.io/badge/Gitpod-ready--to--code-908a85?logo=gitpod)](https://gitpod.io/#https://github.com/sasjs/cli)

[npm-image]: https://img.shields.io/npm/v/@sasjs/cli.svg
[npm-url]: http://npmjs.org/package/@sasjs/cli
Expand Down
2 changes: 1 addition & 1 deletion jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ module.exports = {
global: {
statements: 73.51,
branches: 60.57,
functions: 73.56,
functions: 73.45,
lines: 74.12
}
},
Expand Down
Loading
Loading