[describe-] collect aggr funcs that operate on list of values in Dict #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjakefala
force-pushed
the
aggr-globals
branch
3 times, most recently
from
3f4b292
to
f32c229
Compare
|
@geekscrapy noticed weird behaviour here: #2013 I am marking this PR as draft until this issue is resolved. |
saulpw
reviewed
Sep 1, 2023
anjakefala
force-pushed
the
aggr-globals
branch
2 times, most recently
from
5ff2368
to
fe29f0e
Compare
2 tasks
saulpw
reviewed
Sep 2, 2023
…redDict aggregator() converts a func, which operates on a list, into a _func, which operates on a srccol and a list of rows. The original functions were then added into Globals, but this caused problems for a function like `sum()` which appears naturally in Python code. I created an OrderedDict, and named it aggregators_vals as a place to store them. Other possible options: * We could include the optional funcvals along with func(srccol) for Aggregator. Describe Sheet could then grab the funcvals if it exists. * Describe Sheet could pass the srccol and list of rows, instead of vals. This is not ideal because it means for each aggregator, we call getValues once-more. This would cause a performance degradation. * Add them to vd.aggregators, possibly with the suffix "_vals", and create an Aggregator out of them as well. Have Describe Sheet pull aggrname_vals. * Similarly use the vd.aggregator_vals, but have a less terrible name. Optional: Do we want to do the work of porting quantiles and percentiles to be useable by Describe Sheet? Currently, an aggregator that does not go through aggregator() is not useable by Describe Sheet.
anjakefala
force-pushed
the
aggr-globals
branch
from
40451f4
to
2b66c6f
Compare
saulpw
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In draft until #2008 is merged. We need to make sure the tests are all green. This is needed to fix the vgit build.
aggregator() converts a func, which operates on a list, into a _func, which operates on a srccol and a list of rows.
The original functions were then added into Globals, but this caused problems for a function like
sum()which appears naturally in Python code.I created an OrderedDict, and named it aggregators_vals as a place to store them.
Other possible options:
We could include the optional funcvals along with func(srccol) for Aggregator. Describe Sheet could then grab the funcvals if it exists.
Describe Sheet could pass the srccol and list of rows, instead of vals. This is not ideal because it means for each aggregator, we call getValues once-more. This would cause a performance degradation.
Add them to vd.aggregators, possibly with the suffix "_vals", and create an Aggregator out of them as well. Have Describe Sheet pull aggrname_vals.
Similarly use the vd.aggregator_vals, but have a less terrible name.
Optional: Do we want to do the work of porting quantiles and percentiles to be useable by Describe Sheet? Currently, an aggregator that does not go through aggregator() is not useable by Describe Sheet.