Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Thucydides / Marchant ingestion #182

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

jacobwegner
Copy link
Contributor

No description provided.

…g1:1.1.1

My process was:
- Convert fixture to YAML
- Copy and paste "commentary" from https://sv-ogl-pdl-refwork-53ebd0c14830.herokuapp.com/reader/urn:cts:greekLit:viaf76387703.viaf001.perseus-eng1:1.1.1
- Copy and paste "fragment" from lem element in https://sv-ogl-pdl-refwork-53ebd0c14830.herokuapp.com/library/passage/urn:cts:greekLit:viaf76387703.viaf001.perseus-eng1:1.1.1/xml/
- Cross-reference with the "ve_ref" for urn:cts:greekLit:tlg0003.tlg001.perseus-grc2:1.1.1
- Increment idx and URN numeric parts
- Glaux syntax trees
- Merged token annotations from Glaux and AGDT

@jacobwegner
Copy link
Contributor Author

refs #194

@jacobwegner
Copy link
Contributor Author

@jtauber, re #194, I've got two pending PRs:

Those changes would:

  • Add a distinct "Textual Notes" widget
  • Ingest commentary and textual note annotations separately
  • Overload reader-commentaries-mode to show textual notes and commentary annotations

It may be better to create a new reader-textual-notes mode rather than overloading, but that would require further refactoring of the frontend widgets / components.

@@ -0,0 +1,160 @@
[
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtauber this fixture was created manually from https://github.com/pletcher/canonical_pdlrefwk/blob/6ed59ffa60dda99062ce3f8a712b445f9cdc4554/data/viaf76387703/viaf001/viaf76387703.viaf001.perseus-eng1.xml#L67.

  • references is to the CTS passage
  • commentary supports HTML styling and is content extracted from viaf76387703.viaf001.perseus-eng1.xml
  • fragment is what is shown in the widget sidebar (roughly lem)
  • ve_refs are the token references in the passage (e.g. urn:cts:greekLit:tlg0003.tlg001.perseus-grc2:1.1.1@ Θουκυδίδης == 1.1.1.t1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant