Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to Scalameta 4.10.x #1722

Merged
merged 6 commits into from
Oct 14, 2024
Merged

move to Scalameta 4.10.x #1722

merged 6 commits into from
Oct 14, 2024

Conversation

@SethTisue
Copy link
Member Author

hmm

[scalafix] [error] sbt.librarymanagement.ResolveException: Error downloading ch.epfl.scala:sbt-scalafix;sbtVersion=1.0;scalaVersion=2.12:0.12.1+21-8f7d5d40-SNAPSHOT
[scalafix] [error]   Not found
[scalafix] [error]   Not found
[scalafix] [error]   not found: /home/jenkins/.ivy2/local/ch.epfl.scala/sbt-scalafix/scala_2.12/sbt_1.0/0.12.1+21-8f7d5d40-SNAPSHOT/ivys/ivy.xml
[scalafix] [error]   not found: https://scala-ci.typesafe.com/artifactory/dbuild/ch/epfl/scala/sbt-scalafix_2.12_1.0/0.12.1+21-8f7d5d40-SNAPSHOT/sbt-scalafix-0.12.1+21-8f7d5d40-SNAPSHOT.pom
[scalafix] [error]   not found: https://scala-ci.typesafe.com/artifactory/dbuild-ivy/ch.epfl.scala/sbt-scalafix/scala_2.12/sbt_1.0/0.12.1+21-8f7d5d40-SNAPSHOT/ivys/ivy.xml
[scalafix] [error] 	at lmcoursier.CoursierDependencyResolution.unresolvedWarningOrThrow(CoursierDependencyResolution.scala:346)

@SethTisue
Copy link
Member Author

huh, they are actually depending on a snapshot, with resolvers ++= Resolver.sonatypeOssRepos("snapshots"), as of scalacenter/scalafix@90edc53

@SethTisue
Copy link
Member Author

FAILURES (UNEXPECTED): scalafix,ammonite

for Ammonite to be green again, com-lihaoyi/Ammonite#1528 would have to be merged. I can make a little noise on that PR (and perhaps on Discord), but in the meantime boot Ammonite from the build, they need to keep current on this or we can't keep them in

the scalafix error (https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2122/artifact/logs/scalafix-build.log) is harder to figure

@SethTisue SethTisue changed the title move to Scalameta 4.9.9 move to Scalameta 4.9.9 or 4.10.0 Sep 24, 2024
@SethTisue
Copy link
Member Author

Scalameta 4.10.0 is out, not sure when everybody will upgrade

@SethTisue
Copy link
Member Author

Scalafix upgraded: scalacenter/scalafix#2078

@SethTisue SethTisue changed the title move to Scalameta 4.9.9 or 4.10.0 move to Scalameta 4.10.x Oct 14, 2024
@SethTisue
Copy link
Member Author

🎉🎉🎉, green except for catbird and ammonite. merging. 'll deal with those two separately, probably by ejecting them from the build but letting the maintainers know what they'd need to in order to be included again

@SethTisue SethTisue merged commit 341d73e into scala:2.13.x Oct 14, 2024
@SethTisue SethTisue deleted the scalameta-4.9.9 branch October 14, 2024 21:02
@SethTisue
Copy link
Member Author

ongoing 👏 to @kitbellew and @bjaglin for your efforts

@SethTisue
Copy link
Member Author

catbird, I was able to just disable a subproject; I notified the maintainer

ammonite: removed in ed884b5, but I notified the maintainers at com-lihaoyi/Ammonite#1528

@SethTisue
Copy link
Member Author

Scalameta is failing to extract on JDK 23; this will fix it: scalameta/scalameta#3992

rather than fork temporarily, I'll just hope that gets speedily merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant