-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to Scalameta 4.10.x #1722
move to Scalameta 4.10.x #1722
Conversation
hmm
|
huh, they are actually depending on a snapshot, with |
for Ammonite to be green again, com-lihaoyi/Ammonite#1528 would have to be merged. I can make a little noise on that PR (and perhaps on Discord), but in the meantime boot Ammonite from the build, they need to keep current on this or we can't keep them in the scalafix error (https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2122/artifact/logs/scalafix-build.log) is harder to figure |
Scalameta 4.10.0 is out, not sure when everybody will upgrade |
Scalafix upgraded: scalacenter/scalafix#2078 |
🎉🎉🎉, green except for catbird and ammonite. merging. 'll deal with those two separately, probably by ejecting them from the build but letting the maintainers know what they'd need to in order to be included again |
ongoing 👏 to @kitbellew and @bjaglin for your efforts |
catbird, I was able to just disable a subproject; I notified the maintainer ammonite: removed in ed884b5, but I notified the maintainers at com-lihaoyi/Ammonite#1528 |
Scalameta is failing to extract on JDK 23; this will fix it: scalameta/scalameta#3992 rather than fork temporarily, I'll just hope that gets speedily merged |
https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2119/https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2122/https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2167/https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2169/