This repository has been archived by the owner on Apr 18, 2020. It is now read-only.
WIP: Very early preview of generator merging #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
reviewed
Jan 16, 2018
| sbt.version = 1.1.0-RC4 |
| * | ||
| * They should return the exact identical object thats inputed. | ||
| * | ||
| * Structural equality is slow, thus we want to remain as efficient as possible here. |
There was a problem hiding this comment.
it's possible to implement much faster structural equality than what we currently have, it will still be nut slow compared to referential equality. productPrefix and productIterator and scala.runtime.Statics should do the job.
There was a problem hiding this comment.
another undocumented point is that Tree.origin (private[meta]) contains the position and is preserved during tree transforms, this can also be used to test equality.
|
Closing as the real impl will be based on #52 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: For #44
I messed with this before christmas.
A couple of notes: