Remove rubocop #561
Merged
Remove rubocop #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the one hand, I don't think "_why didn't use Rubocop" wouldn't be enough reason by itself. On the other hand, I 100% agree with this decision :-) I think Rubocop's emphasis on uniformity is very wrong for both _why and Shoes. We want weird stuff happening in our playpen. And _why was a big fan of weirdness in the interface and the implementation. |
|
Totally! However one biproduct of this is my editor does do a certain amount of autoformatting, which I enjoy in personal coding. so if I touch a file and my editor makes small non-blocking changes I'm unlikely to just go and change my development setup for one repo! |
|
just a side note for future PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_why didn't use rubocop.