Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rubocop #561

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Remove rubocop #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,3 @@ jobs:
with:
name: test failure logs
path: logger/test_failure*.out.log
# linter:
# name: Linter
# runs-on: macos-latest
# timeout-minutes: 10
# steps:
# - name: Install dependencies
# run: brew install pkg-config portaudio
# - name: Checkout code
# uses: actions/checkout@v4
# - name: Setup Ruby and install gems
# uses: ruby/setup-ruby@v1
# with:
# bundler-cache: true
# - name: Run linter
# run: bundle exec rubocop
94 changes: 0 additions & 94 deletions .rubocop.yml
View file
Open in desktop

This file was deleted.

42 changes: 17 additions & 25 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# frozen_string_literal: true

require "bundler/gem_tasks"
require "rake/testtask"
require "rubocop/rake_task"
require 'bundler/gem_tasks'
require 'rake/testtask'

# Rakefile

Expand All @@ -13,20 +12,18 @@ task :ci_test do

system('brew install pkg-config portaudio')


puts "
\033[1;32;4;47mCheckout Code\033[0m
"
system('git checkout main')


puts "
\033[1;32;4;47mSetup Ruby and install Gems\033[0m
"
system('bundle install')

# Run tests

puts "
\033[1;32;4;47mRun Lacci Tests\033[0m
"
Expand All @@ -38,57 +35,52 @@ task :ci_test do

system('CI_RUN=true bundle exec rake component_test')


puts "
\033[1;32;4;47mRun Scarpe Tests\033[0m
"
system('CI_RUN=true bundle exec rake test')


puts "
\033[1;32;4;47mCheck HTML Output\033[0m
"
system('bundle exec rake test:check_html_fixtures')


puts "
\033[1;32;4;47mUpload Fail logs\033[0m
"
system('if [ ! -z "$(ls logger/test_failure*.out.log 2>/dev/null)" ]; then actions/upload-artifact@v4 --name "test failure logs" --path logger/test_failure*.out.log; fi')
end

Rake::TestTask.new(:test) do |t|
t.libs << "test"
t.libs << "lib"
t.test_files = FileList["test/**/test_*.rb"]
t.libs << 'test'
t.libs << 'lib'
t.test_files = FileList['test/**/test_*.rb']
end

Rake::TestTask.new(:lacci_test) do |t|
t.libs << "lacci/test"
t.libs << "lacci/lib"
t.test_files = FileList["lacci/test/**/test_*.rb"]
t.libs << 'lacci/test'
t.libs << 'lacci/lib'
t.test_files = FileList['lacci/test/**/test_*.rb']
end

Rake::TestTask.new(:component_test) do |t|
t.libs << "scarpe-components/test"
t.libs << "scarpe-components/lib"
t.test_files = FileList["scarpe-components/test/**/test_*.rb"]
t.libs << 'scarpe-components/test'
t.libs << 'scarpe-components/lib'
t.test_files = FileList['scarpe-components/test/**/test_*.rb']
end

namespace :test do
desc 'Regenerate HTML fixtures'
task :regenerate_html_fixtures do |t|
ENV['SELECTED_FILE'] = ARGV[-1] if ARGV[-1].include?(".rb")
task :regenerate_html_fixtures do |_t|
ENV['SELECTED_FILE'] = ARGV[-1] if ARGV[-1].include?('.rb')
load 'tasks/regenerate_html_fixtures.rb'
end

desc 'Check HTML fixtures against latest output'
task :check_html_fixtures do |t|
ENV['SELECTED_FILE'] = ARGV[-1] if ARGV[-1].include?(".rb")
task :check_html_fixtures do |_t|
ENV['SELECTED_FILE'] = ARGV[-1] if ARGV[-1].include?('.rb')
load 'tasks/check_html_fixtures.rb'
end
end

RuboCop::RakeTask.new

task default: [:test, :lacci_test, :component_test]
task default: %i[test lacci_test component_test]
2 changes: 0 additions & 2 deletions lacci/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ group :development do
gem "yard"
gem "redcarpet"
gem "debug"
gem "rubocop", "~> 1.21"
gem "rubocop-shopify"
#gem "commonmarker"
#gem "github-markup"
end
30 changes: 1 addition & 29 deletions lacci/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,54 +13,28 @@ GEM
remote: https://rubygems.org/
specs:
ansi (1.5.0)
ast (2.4.2)
builder (3.2.4)
debug (1.8.0)
irb (>= 1.5.0)
reline (>= 0.3.1)
io-console (0.6.0)
irb (1.7.2)
reline (>= 0.3.6)
json (2.6.3)
language_server-protocol (3.17.0.3)
minitest (5.18.1)
minitest-reporters (1.6.0)
ansi
builder
minitest (>= 5.0)
ruby-progressbar
parallel (1.23.0)
parser (3.2.2.3)
ast (~> 2.4.1)
racc
racc (1.7.1)
rainbow (3.1.1)
rake (13.0.6)
redcarpet (3.6.0)
regexp_parser (2.8.1)
reline (0.3.6)
io-console (~> 0.5)
rexml (3.2.5)
rubocop (1.54.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.3)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.29.0)
parser (>= 3.2.1.0)
rubocop-shopify (2.14.0)
rubocop (~> 1.51)
ruby-progressbar (1.13.0)
unicode-display_width (2.4.2)
yard (0.9.34)

PLATFORMS
arm64-darwin-21
x86_64-darwin-22

DEPENDENCIES
Expand All @@ -70,8 +44,6 @@ DEPENDENCIES
minitest-reporters
rake (~> 13.0)
redcarpet
rubocop (~> 1.21)
rubocop-shopify
scarpe-components!
yard

Expand Down
2 changes: 0 additions & 2 deletions scarpe-components/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@ end

group :development do
gem "debug"
gem "rubocop", "~> 1.21"
gem "rubocop-shopify"
end
32 changes: 1 addition & 31 deletions scarpe-components/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ GEM
remote: https://rubygems.org/
specs:
ansi (1.5.0)
ast (2.4.2)
base64 (0.1.1)
builder (3.2.4)
debug (1.8.0)
irb (>= 1.5.0)
Expand All @@ -23,51 +21,25 @@ GEM
irb (1.8.0)
rdoc (~> 6.5)
reline (>= 0.3.6)
json (2.6.3)
language_server-protocol (3.17.0.3)
minitest (5.19.0)
minitest-reporters (1.6.1)
ansi
builder
minitest (>= 5.0)
ruby-progressbar
parallel (1.23.0)
parser (3.2.2.3)
ast (~> 2.4.1)
racc
psych (5.1.0)
stringio
racc (1.7.1)
rainbow (3.1.1)
rake (13.0.6)
rdoc (6.5.0)
psych (>= 4.0.0)
regexp_parser (2.8.1)
reline (0.3.8)
io-console (~> 0.5)
rexml (3.2.6)
rubocop (1.56.2)
base64 (~> 0.1.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.3)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.1, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.29.0)
parser (>= 3.2.1.0)
rubocop-shopify (2.14.0)
rubocop (~> 1.51)
ruby-progressbar (1.13.0)
stringio (3.0.8)
unicode-display_width (2.4.2)
webrick (1.8.1)

PLATFORMS
arm64-darwin-21
x86_64-darwin-22

DEPENDENCIES
Expand All @@ -76,8 +48,6 @@ DEPENDENCIES
minitest (~> 5.0)
minitest-reporters
rake (~> 13.0)
rubocop (~> 1.21)
rubocop-shopify
scarpe-components!
webrick

Expand Down