Skip to content

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Oct 5, 2025

error: you are deriving `Hash` but have implemented `PartialEq` explicitly
   --> rust/scx_utils/src/energy_model.rs:27:28
    |
 27 | #[derive(Debug, Clone, Eq, Hash, Ord, PartialOrd)]

Copy link
Contributor

@JakeHillion JakeHillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this the correct fix over deriving PartialEq? It seems to make the code more complex and more likely to get out of sync.

@devnexen
Copy link
Contributor Author

devnexen commented Oct 6, 2025

It s not a required fix but I thought you would prefer to keep the PartialEq implementation (which seems to be just the same as the default behavior anyway).

error: you are deriving `Hash` but have implemented `PartialEq` explicitly
   --> rust/scx_utils/src/energy_model.rs:27:28
    |
 27 | #[derive(Debug, Clone, Eq, Hash, Ord, PartialOrd)]
@devnexen devnexen force-pushed the energy_model_clippy_fix branch from a7bafc8 to 26c4143 Compare October 6, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants