Skip to content

scx_utils: fix clippy error. #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −17
Open

scx_utils: fix clippy error. #2852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions rust/scx_utils/src/energy_model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ use std::fmt;
use std::path::Path;
use std::sync::Arc;

#[derive(Debug, Clone, Eq, Hash, Ord, PartialOrd)]
#[derive(Debug, Clone, Eq, Hash, Ord, PartialEq, PartialOrd)]
pub struct PerfState {
pub cost: usize,
pub frequency: usize,
Expand All @@ -33,7 +33,7 @@ pub struct PerfState {
pub power: usize,
}

#[derive(Debug, Clone, Eq, Hash, Ord, PartialOrd)]
#[derive(Debug, Clone, Eq, Hash, Ord, PartialEq, PartialOrd)]
pub struct PerfDomain {
/// Monotonically increasing unique id.
pub id: usize,
Expand Down Expand Up @@ -130,12 +130,6 @@ impl PerfDomain {
}
}

impl PartialEq for PerfDomain {
fn eq(&self, other: &Self) -> bool {
self.id == other.id && self.span == other.span && self.perf_table == other.perf_table
}
}

impl PerfState {
/// Build a PerfState
pub fn new(root: String) -> Result<PerfState> {
Expand All @@ -155,15 +149,6 @@ impl PerfState {
}
}

impl PartialEq for PerfState {
fn eq(&self, other: &Self) -> bool {
self.cost == other.cost
&& self.frequency == other.frequency
&& self.performance == other.performance
&& self.power == other.power
}
}

impl fmt::Display for EnergyModel {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
for (_, pd) in self.perf_doms.iter() {
Expand Down