Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] add synthbet option to preproc_t1 #169

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

anroy1
Copy link
Contributor

@anroy1 anroy1 commented Jul 4, 2024

Describe your changes

Add the synthbet option to preproc_t1

List test packages used by your module

  • antsbet.zip
  • others.zip

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

To Do

Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two small comments, great work 💯 Once addressed, this should be good to go !

subworkflows/nf-scil/preproc_t1/main.nf Outdated Show resolved Hide resolved
subworkflows/nf-scil/preproc_t1/main.nf Outdated Show resolved Hide resolved
subworkflows/nf-scil/preproc_t1/main.nf Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants