Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jj update to latest version #15

Merged
merged 24 commits into from
Feb 28, 2023
Merged

Jj update to latest version #15

merged 24 commits into from
Feb 28, 2023

Conversation

JorMaister
Copy link
Collaborator

No description provided.

@JorMaister JorMaister marked this pull request as draft September 30, 2022 09:36
@tibuch tibuch marked this pull request as ready for review October 4, 2022 12:50
@tibuch
Copy link
Collaborator

tibuch commented Oct 4, 2022

Oh sorry! I did not want to change it from Draft to Review requested. I actually wanted to ask if I should already start the review or wait?

Was to eager to try out this button 😄

@tibuch tibuch marked this pull request as draft October 4, 2022 12:52
@JorMaister
Copy link
Collaborator Author

No worries, Tim-Oliver!

I moved it to draft because I found something when I was making some tests. I've written the description in the corresponding g issue of the source repo.

juglab/cryoCARE_pip#29

@pconesa
Copy link
Contributor

pconesa commented Oct 5, 2022

Installation of cryoCARE and tests worked like a charm.

@JorMaister JorMaister marked this pull request as ready for review December 23, 2022 18:15
cryocare/__init__.py Outdated Show resolved Hide resolved
@MohamadHarastani
Copy link

Hi @JorMaister can you merge it?

@MohamadHarastani MohamadHarastani linked an issue Feb 16, 2023 that may be closed by this pull request
@JorMaister
Copy link
Collaborator Author

@pconesa?

@MohamadHarastani
Copy link

I noticed that the output tomogram name has an extra underscore.. other than that all is good!

@pconesa
Copy link
Contributor

pconesa commented Feb 23, 2023

Sorry, I'm busy these days. Will find time soon

@pconesa pconesa merged commit 56a8bda into devel Feb 28, 2023
@pconesa pconesa deleted the jj_update_installer branch February 28, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation error with numpy and test failure
5 participants