sort TS/TSM by tsId #567
Open
sort TS/TSM by tsId #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
From my side, I think it's a good change, and some users have requested the items to appear sorted by tsId in the tree. What do you think, @pconesa, @fonsecareyna82, @Vilax ? |
|
I think it's a good idea, but changes would have to be made to the tree class of core.... and I don't know how this would affect other scipion trees. |
|
One more thing is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the ORDER_DICT was not used, and the items would be sorted by id. Now, the TS/TSM are sorted by TSID. This change slows down the first-time viewer opening if you have lots of items, so I'm open to discussion.