Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template sync #222

Merged
merged 44 commits into from
Nov 28, 2023
Merged

Fix template sync #222

merged 44 commits into from
Nov 28, 2023

Conversation

grst
Copy link
Collaborator

@grst grst commented Aug 4, 2023

  • Wrap in try...except to keep updating other repos if one fails
  • dont make pr on repo if already exists for current version
  • exit 1, if at least one job has failed
  • Execute on all repos (instead of just "infercnvpy")

Close #208

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#81

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

scripts/pyproject.toml Outdated Show resolved Hide resolved
@grst
Copy link
Collaborator Author

grst commented Aug 9, 2023

@flying-sheep, do you have any clue why the test is failing? Locally all tests pass...

@grst
Copy link
Collaborator Author

grst commented Aug 9, 2023

The "real" sync run was successful 🎉.

A couple of repos failed, but the script recovered gracefully. I set the respective repos to skip in scverse/ecosystem-packages@10c060c.

@grst grst mentioned this pull request Aug 9, 2023
4 tasks
@flying-sheep
Copy link
Member

awesome! Once the script tests are fixed properly, we can really call this done (well, actually expanding the tests wouldn’t hurt either)

@grst
Copy link
Collaborator Author

grst commented Aug 23, 2023

@flying-sheep, could you please take a look at the tests? I don't understand why they are failing and can't reproduce the failure locally.

@grst grst merged commit ff4b39a into main Nov 28, 2023
7 checks passed
@grst grst deleted the v0.2.x branch November 28, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish centralized template sync
2 participants